Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Publish with decendants structure reload #2486

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Hotfix: Publish with decendants structure reload #2486

merged 7 commits into from
Oct 28, 2024

Conversation

madsrasmussen
Copy link
Contributor

Description

Fixes: umbraco/Umbraco-CMS#17345

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen changed the title Hotfix: Publish with decendants tree reload Hotfix: Publish with decendants structure reload Oct 25, 2024
@leekelleher leekelleher self-requested a review October 28, 2024 10:32
@leekelleher leekelleher enabled auto-merge (squash) October 28, 2024 10:41
leekelleher
leekelleher approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, works as expected! 🎉

@leekelleher leekelleher merged commit 3bec2cb into release/15.0 Oct 28, 2024
9 checks passed
@leekelleher leekelleher deleted the v15/hotfix/17345/publish-with-decendants branch October 28, 2024 10:41
@leekelleher leekelleher mentioned this pull request Oct 28, 2024
Closed
nielslyngsoe pushed a commit that referenced this pull request Nov 4, 2024
@madsrasmussen @nielslyngsoe
Hotfix: Publish with decendants structure reload (#2486)
64addff 
* ensure we always have the latest variant data

* use enum value

* Update document-tree-item.element.ts

* only dispatch event if there is no error

* reload structure after publish with descendants

* only request update if it succeeds

* rename private method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees
No one assigned
Labels
release/15.0.0-rc3 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @leekelleher