Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: deprecate manifest types type #2490

Merged
merged 1 commit into from
Oct 28, 2024
Merged

hotfix: deprecate manifest types type #2490

merged 1 commit into from
Oct 28, 2024

Conversation

nielslyngsoe
Copy link
Member

Removes ManifestTypes type, to direct developers to this annoncement:
umbraco/Announcements#22

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@madsrasmussen madsrasmussen changed the base branch from main to release/15.0 October 28, 2024 12:59
madsrasmussen
madsrasmussen approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🥇

@madsrasmussen madsrasmussen merged commit 57664ef into release/15.0 Oct 28, 2024
8 of 9 checks passed
@madsrasmussen madsrasmussen deleted the v15/hotfix/deprecate-manifest-types-type branch October 28, 2024 13:16
@nielslyngsoe nielslyngsoe changed the title V15/hotfix/deprecate manifest types type hotfix: deprecate manifest types type Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
category/breaking release/15.0.0-rc3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @madsrasmussen