uui-toggle: icons doesn't look great

[bjarnef]

Which exact UI Library version are you using? For example: 1.0.1 - don't just write v1.

1.6.0-rc

Bug summary

I noticed the icons doesn't look great in backoffice after the new Lucide icons , but should probably be fixed in UI library.

Specifics

No response

Steps to reproduce

Check uui-toggle component with check and cross icons.

The new icon-wrong is this icon https://lucide.dev/icons/x-circle ... but this icon is more similar to the current "wrong" icon in the current backoffice: https://lucide.dev/icons/x

Expected result / actual result

No response

[nielslyngsoe]

I came to create this exact issue.

Feel free to correct.

Here is how I see it:

#icon-wrong should be changed to #icon-remove — in this case its maybe just a direct reference to the SVG. that okay but then that svg should be changed. (This is the same change as @bjarnef is referring to. )

#icon-check and #icon-wrong/#icon-close should be colored via color: not fill:

[bjarnef]

@nielslyngsoe not sure how the existing SVG icons should be changed or we just should stay with the new icon name in Lucide icons and then change e.g. icon name used in Lucide icon set. I think it otherwise may be confusing to find the icon?

I think we should strive to make core looks pretty and then developers migrating to Umbraco 14 (new backoffice) and eventually Umbraco addons need to update a few icon names.

The old icon set was solid icons and therefor using fill .. the new icons are outline icons as far I know and therefore using color to fill stroke? .. how would it eventually affect custom icons, e.g. the solid Umbraco logo/icon. With the new icons should there be an outline Umbraco icon as well? E.g. similar to the one used here: https://twitter.com/umbracoproject

[nielslyngsoe]

This is fixed previously so I'm closing this issue.