add new check on alpha to check if undefined #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
approved these changes
Apr 4, 2025
bjarnef
reviewed
Apr 7, 2025
| @@ -379,7 +379,7 @@ export class UUIColorPickerElement extends LabelMixin('label', LitElement) { | |||
| this.hue = h; | |||
| this.saturation = s; | |||
| this.lightness = l; | |||
| this.alpha = this.opacity ? a * 100 : 100; | |||
| this.alpha = this.opacity != undefined ? a * 100 : 100; | |||
There was a problem hiding this comment.
Not sure how opacity can be undefined? It's a boolean property with false as default value.
In the story it set value: undefined.
I guess it is more likely a from parsed color which is undefined or null, if value property is defined/null.
iOvergaard
requested changes
Apr 11, 2025
There was a problem hiding this comment.
I think @bjarnef has a point here and would like to get it investigated before merging.
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1061.westeurope.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks to this.alpha
Description
Added a new check in to alpha to check if the value for the color picker is defined or not.
if the value is undefined, it will default the alpha to 100
Types of changes
Motivation and context
This is to improve the UX for when user is picking a new color
How to test?
Using the eye dropper color picker data type, when on a content node of the content tree, if you click on the round colour selection palette to change the colour, you will see that the default opacity is 100 now
Screenshots (if appropriate)
Checklist