Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis connection fix #7

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Redis connection fix #7

merged 6 commits into from
Aug 8, 2023

Conversation

qem19
Copy link
Member

@qem19 qem19 commented Aug 3, 2023

Laravel doesnt have ability to use different redis-clients for different connections. It can be problem if you want to use sentinel-connection for app and phpredis for metrics.

So, in the PR i changed redis config for Prometheus. Now, you can specify redis-client and all credentials right in event-tracker.php config

@coveralls
Copy link

coveralls commented Aug 3, 2023

Pull Request Test Coverage Report for Build 5749179287

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 46.352%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Repositories/PrometheusRepository/Installer.php 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/Repositories/PrometheusRepository/Installer.php 5 40.0%
Totals Coverage Status
Change from base Build 4436525562: -0.8%
Covered Lines: 108
Relevant Lines: 233

💛 - Coveralls

@qem19 qem19 merged commit b0a8c1a into master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants