-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types for better intellisense #14
Conversation
Good idea, I'm totally for it. But I think we need to discuss it with other teammates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool work, looks good to me 👍
I assume changes require to patch package version, set it to 1.4.2 Is there anything that should be done before merge? |
Yeah, it should be fine.
Before merging – no (as far as I remember), but the package needs to be re-bundled before publishing. |
Well, as I'm able to, gonna merge then 😎 |
It's weird that after merge was done coverage badge value somehow has been decreased despite nothing did indicate or warn :( |
All the jobs are completed successfully, and a coverage report shows us 100%, so I guess it's a coveralls issue. |
This is somewhat naive attempt to provide intellisense with JSDoc
Please help with review and suggesting types and stuff
Maybe it is possible to even use TypeScript instead of JSDoc?