Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable and investigate ibctransfer failing tests #1259

Closed
4 tasks done
robert-zaremba opened this issue Aug 22, 2022 · 0 comments · Fixed by #1280
Closed
4 tasks done

Reenable and investigate ibctransfer failing tests #1259

robert-zaremba opened this issue Aug 22, 2022 · 0 comments · Fixed by #1280
Assignees
@brianosaurus @robert-zaremba @RafilxTenfen
Labels
C:IBC T:Bug A regression or bug in the Umee codebase.
Milestone
v3

Comments

@robert-zaremba
Copy link
Member

robert-zaremba commented Aug 22, 2022 •
edited
Loading

Summary

We migrated to IBC v3.1 in #1217 (related to a huge work to Cosmos v0.46 upgrade).
However this migration caused x/ibctransfer (our umee wrapper) tests to fail:

failed to execute message; message index: 0: connection handshake open try failed: failed connection state verification for client (07-tendermint-0): chained membership proof contains nonexistence proof at index 0. If this is unexpected, please ensure that proof was queried from a height that contained the value in store and was queried with the correct key. The key used: /ibc/connections%2Fconnection-0: invalid proof

Ref: https://github.com/umee-network/umee/runs/7942798895?check_suite_focus=true

Proposal

Remove the Skip statement and investigate the issue.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added T:Bug A regression or bug in the Umee codebase. C:IBC labels Aug 22, 2022
@robert-zaremba robert-zaremba added this to the v3 - Calypso milestone Aug 22, 2022
@robert-zaremba robert-zaremba mentioned this issue Aug 25, 2022
Merged
17 tasks
mergify bot pushed a commit that referenced this issue Sep 11, 2022
@robert-zaremba
test: re-enaable ibctransfer wrapper test suite (#1280)
0afaf70 
## Description

Closes: #1259 

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@mergify mergify bot closed this as completed in #1280 Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianosaurus brianosaurus

@robert-zaremba robert-zaremba

@RafilxTenfen RafilxTenfen

Labels
C:IBC T:Bug A regression or bug in the Umee codebase.
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

test: re-enaable ibctransfer wrapper test suite umee-network/umee
3 participants
@brianosaurus @robert-zaremba @RafilxTenfen