Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price-feeder: Add FTX Provider #1276

Closed
4 tasks
Tracked by #1287
adamewozniak opened this issue Aug 24, 2022 · 1 comment · Fixed by #1299
Closed
4 tasks
Tracked by #1287

Price-feeder: Add FTX Provider #1276

adamewozniak opened this issue Aug 24, 2022 · 1 comment · Fixed by #1299
Assignees
@adamewozniak
Labels
C:Price-Feeder C:x/oracle

Comments

@adamewozniak
Copy link
Collaborator

Summary

We should add the FTX websocket API to the price feeder for additional support of our stablecoin conversions: https://docs.ftx.com/#overview

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adamewozniak adamewozniak mentioned this issue Aug 25, 2022
Closed
4 tasks
@adamewozniak adamewozniak self-assigned this Aug 25, 2022
@adamewozniak adamewozniak mentioned this issue Aug 25, 2022
Closed
15 tasks
@adamewozniak adamewozniak changed the title Price-feeder: Add FTX websocket API Price-feeder: Add FTX Provider Aug 29, 2022
@adamewozniak
Copy link
Collaborator Author

Looks like the websocket API might only give us tickers.

Let's rate limit to be sub-30 requests per second and hit their rest endpoint to get candles.

Candles requires Price, Volume, and Timestamp, whereas Tickers require only last trade Price & Volume.

@adamewozniak adamewozniak mentioned this issue Aug 29, 2022
Merged
17 tasks
@mergify mergify bot closed this as completed in #1299 Aug 30, 2022
mergify bot pushed a commit that referenced this issue Aug 30, 2022
@adamewozniak
feat(price-feeder): add ftx (#1299)
cdb582c 
## Description

Adds FTX as a provider

closes: #1276 

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamewozniak adamewozniak

Labels
C:Price-Feeder C:x/oracle
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(price-feeder): add ftx umee-network/umee
1 participant
@adamewozniak