Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error check to in leverage simulations TestWeightedOperations #1310

Closed
4 tasks
robert-zaremba opened this issue Aug 30, 2022 · 1 comment · Fixed by #1300
Closed
4 tasks

Add error check to in leverage simulations TestWeightedOperations #1310

robert-zaremba opened this issue Aug 30, 2022 · 1 comment · Fixed by #1300

Comments

@robert-zaremba
Copy link
Member

Summary

The w.Op()(r, s.app.BaseApp, s.ctx, accs, "") returns an error which is not checked.
https://github.com/umee-network/umee/blob/v3.0.0-alpha2/x/leverage/simulation/operations_test.go#L159


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@toteki
Copy link
Member

toteki commented Aug 31, 2022

Added fix to #1300

toteki added a commit that referenced this issue Sep 1, 2022
* supply and withdraw tests

* err--

* make proto-all

* error improvements and fix cascading client test error DEVX

* TestCollateralize

* ++

* TestDe+Collateralize

* case++

* borrow test + more cases

* add invariant checks to every msg test case

* move files

* ++

* TestRepay

* --

* Liquidate single-denom test cases

* liquidate cases

* --

* remove setupAccount and initBorrowScenario

* imports

* lint++

* fix test

* ++

* cl++

* remove unnecessary interface

* move function

* apply s.app, s.ctx, and s.Require() shorthands

* apply coin shorthand in keeper_test package

* use setReserves helper

* improve big number readability

* ensure espected value is on the left for all require.Equal

* use borrow and repay helpers

* lint++

* always require.ErrorIs

* use forceBorrow helper rather than SetTokenSettings in high utilization test

* fix #1310

* fix sim tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants