Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not required invariants in x/leverage endblocker #1324

Closed
4 tasks done
robert-zaremba opened this issue Sep 2, 2022 · 1 comment · Fixed by #1362
Closed
4 tasks done

Remove not required invariants in x/leverage endblocker #1324

robert-zaremba opened this issue Sep 2, 2022 · 1 comment · Fixed by #1362
Assignees
@toteki
Labels
C:x/leverage
Milestone
v3

Comments

@robert-zaremba
Copy link
Member

Summary

Nice to have for v3, otherwise we move it to v4.

Don't use compute intensive invariants in endblocker

Problem Definition

Endblocker operations should be strictly minimum. Only required operations should happen there:

  • no-one is paying for that operations
  • all possible verification should happen at the tx level
  • too time intensive operations can be dangerous for consensus (if operation will stuck somewhere or will impact the block time).
  • finally they can cause chain halt.

#1300 added more invariants and we should rethink them.

Proposal

  • Use only strictly required invariants in the endblocker
  • other invariants should be only applied for genesis load.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added this to the v3 - Calypso milestone Sep 2, 2022
@robert-zaremba robert-zaremba mentioned this issue Sep 2, 2022
Merged
17 tasks
@toteki
Copy link
Member

toteki commented Sep 2, 2022

We should specifically remove the "iterate all balances" invariants, but there's no scaling problem with the "iterate all denoms" ones.

This was referenced Sep 2, 2022
Closed
Merged
@mergify mergify bot closed this as completed in #1362 Sep 9, 2022
mergify bot pushed a commit that referenced this issue Sep 9, 2022
@toteki
fix: for inefficient invariants, use only in tests (#1362)
1867a9e 
## Description

closes: #1324 

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toteki toteki

Labels
C:x/leverage
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

fix: for inefficient invariants, use only in tests umee-network/umee
2 participants
@robert-zaremba @toteki