Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetTickerPrice() and GetCandlePrices() in price feeder providers to not return nothing if some pairs don't have price data #1757

Closed
4 tasks
Tracked by #1760
rbajollari opened this issue Jan 30, 2023 · 0 comments · Fixed by #1767
Assignees

Comments

@rbajollari
Copy link
Contributor

Summary of Bug

GetTickerPrice() and GetCandlePrices() will return no price data if even just one pair doesn't have price data. These methods should still return prices for pairs that have it available and log a warning about pairs that don't have price data, rather than completely error out when one pair doesn't.

Version

Please provide the output of the following commands:

  • $ umeed version
  • $ go version
  • $ uname -a

Steps to Reproduce

Steps to reproduce the behavior:

  1. ...

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant