Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GetTickerPrice() and GetCandlePrices() in providers still returns available ticker or candle data if not all currency pairs error #1767

Merged
merged 5 commits into from
Feb 3, 2023

Conversation

rbajollari
Copy link
Contributor

Description

closes: #1757

  • Added two new error types in errors.go for when a provider has no ticker or candle data.
  • If any individual currency pair can't return a ticker or candle, GetTickerPrice() and GetCandlePrices() will log a warning for that pair and only return an error back if all the currency pairs it was asked to return return an error.
  • Updated provider tests to check for new error message returned from GetTickerPrice() and GetCandlePrices()

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari marked this pull request as ready for review January 31, 2023 16:49
@rbajollari rbajollari requested a review from a team as a code owner January 31, 2023 16:49
@rbajollari rbajollari merged commit 075b493 into main Feb 3, 2023
@rbajollari rbajollari deleted the ryan/get-ticker-candle branch February 3, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants