-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(token registry): proto max collateral share #1096
Conversation
518c105
to
063768a
Compare
For clarity, what is an example of this in use? Option 1 - If I'm understanding correctly:
Option 2 - if I'm misunderstanding the wording, this was another possibility
Am I correct in assuming this proposal is the first option? |
I will add ADR update once this will get merged with a proper example. Option 1 is the valid one - see the linked issue - it has more details.
This is a good and valid point. The restriction will only hold when adding a collateral. |
We might also solicit naming advice for this parameter in discussion tomorrow.
|
How about |
MaxCollateralSupply (wrong meaning) |
Renamed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a little housekeeping (see commits) - approving now.
Codecov Report
@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
+ Coverage 43.55% 43.82% +0.27%
==========================================
Files 65 65
Lines 8390 8393 +3
==========================================
+ Hits 3654 3678 +24
+ Misses 4486 4472 -14
+ Partials 250 243 -7
|
Description
ref: #1095
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...