-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add MaxCollateralShare, MaxSupplyUtilization, and MinCollateralLiquidity #1141
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 43.82% 43.89% +0.07%
==========================================
Files 65 65
Lines 8393 8417 +24
==========================================
+ Hits 3678 3695 +17
- Misses 4472 4477 +5
- Partials 243 245 +2
|
This is an architecture change. I would strongly prefer that we do that changes step by step:
|
This PR as been split up:
After those merge, I will take the remaining code in this PR (i.e. the implementation of MaxSupplyUtilization and related calculations), turn them into a small PR, and close this. |
seams like we can close now to avoid confusions. You can keep your branch locally. |
Description
Also
MaxSupplyUtilization
closes: #1093 #1095 #1036 and some other things that weren't made into issues first
Currently backtracks on #1107 due to second thoughts - see discussion
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...