-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GetComputedPrices panic #1262
Conversation
This is a temporary solution to avoid panic on price-feeder we should investigate the correct behavior of umee/price-feeder/oracle/util.go Lines 72 to 73 in e41fa2c
|
If this is a temporary solution should there be a comment in the code to explain that. And maybe a corresponding github issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Done at dc31d38 |
…mputed-price-panic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple nitpicks but lgtm 👍
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Description
related to: #1261
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...