-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: safeguard LastInterestTime against hard forks #1288
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
+ Coverage 51.34% 51.57% +0.22%
==========================================
Files 68 68
Lines 6834 6852 +18
==========================================
+ Hits 3509 3534 +25
+ Misses 3067 3061 -6
+ Partials 258 257 -1
|
can we backport this to 2.x.x ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a bit more comments? You are investigating cases which potentially are not possible. It's OK to make that check, but let's describe it for completness when these things can happen. Otherwise it's a bit confusing.... it's like checking if 2+2 > 0
.
Scenarios where time difference of a year would be possible
Curiously, the |
Yeah (might take a few manual adjustments on the backport PR). Also I need to add a gov proposal types to adjust interest scalar and set reserve amounts - those will be a separate PR but if we backport them rather than modifying genesis file, we could fix Asherah-2 with a binary swap + proposals instead of directly editing genesis. Might be faster to just edit the file though. |
Description
This will prevent the excessive (~10^20 factor) interest accrued during our hard fork of asherah testnet, where we modified LastInterestTime in genesis.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...