-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: price-feeder version #1291
Conversation
Hey @rbajollari, So the idea is that the An idea how to do that it to look how umeed is doing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the pattern of setting a version during the build time:
- https://github.com/umee-network/umee/blob/main/Makefile#L62
- https://github.com/umee-network/umee/blob/main/Makefile#L72
You need to adopt it in price-feeder by adding Version
variable to price-feeder/main.go
and setting it through ldflags as outlined above.
8be4bf0
to
d8748c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me!
@robert-zaremba please check this out when you can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK, just a question on umeed we have umeed version
which just returns like main-1f36d964a9449cb307806bef68eb90197b845274
and the --long
flag, which it prints all the build deps, build flags used and cosmos SDK version
What do you think about following that pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Hmm, we could add a task to add the "--long" flag, but atm I think the contents of this PR are enough (we mostly care about commit # and cosmos version with this tool) - wdyt @RafilxTenfen / @rbajollari ? |
Agree |
…on command
Description
closes: #1281
This bug is happening because the price-feeder version command is trying to open the go.mod file of the price-feeder but if you're outside of that directory it doesn't know where that go.mod file is. My proposed solution is to add an argument to the version command for the directory of the price-feeder in your environment. Let me know if you have a better way to approach this.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...