Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve CI workflow #1367

Merged
merged 57 commits into from
Sep 14, 2022
Merged

feat: improve CI workflow #1367

merged 57 commits into from
Sep 14, 2022

Conversation

RafilxTenfen
Copy link
Contributor

@RafilxTenfen RafilxTenfen commented Sep 10, 2022

Description

  • Added cache for umeed v103 and mainnet tinkered genesis
  • Add dependencies between workflows for already built binaries for linux amd64
  • removed deprecated rokroskar/workflow-run-cleanup-action@master

Overview of tests.yml
image


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RafilxTenfen RafilxTenfen self-assigned this Sep 12, 2022
@RafilxTenfen RafilxTenfen changed the title testing cache feat: improve CI workflow Sep 12, 2022
@RafilxTenfen
Copy link
Contributor Author

@RafilxTenfen
Copy link
Contributor Author

@robert-zaremba @toteki anyone against merging it?

Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
@toteki
Copy link
Member

toteki commented Sep 14, 2022

Looks good - I didn't test any local runs though. Commented on some typos

RafilxTenfen and others added 4 commits September 14, 2022 13:01
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
@RafilxTenfen RafilxTenfen requested a review from a team as a code owner September 14, 2022 16:05
@RafilxTenfen
Copy link
Contributor Author

@RafilxTenfen RafilxTenfen merged commit 71b0d68 into main Sep 14, 2022
@RafilxTenfen RafilxTenfen deleted the rafilx/ci-upgrade-handler-asset branch September 14, 2022 16:58
Copy link
Contributor

@khoerling khoerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants