Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: leverage proto docs update #1370

Merged
merged 17 commits into from
Sep 18, 2022
Merged

docs: leverage proto docs update #1370

merged 17 commits into from
Sep 18, 2022

Conversation

robert-zaremba
Copy link
Member

Description

Updates related to #1369


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested a review from a team as a code owner September 12, 2022 11:26
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to avoid the ASCII graphs, especially since these are being formatted into other docs.

Also, make sure to make proto-all to include swagger.

proto/umee/leverage/v1/leverage.proto Outdated Show resolved Hide resolved
proto/umee/leverage/v1/leverage.proto Outdated Show resolved Hide resolved
robert-zaremba and others added 2 commits September 13, 2022 12:56
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
@robert-zaremba
Copy link
Member Author

buf CI error fixed in #1397

@mergify mergify bot merged commit ee334f2 into main Sep 18, 2022
@mergify mergify bot deleted the robert/leverage-docs branch September 18, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants