Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require compile-time flag to enable liquidator query #1395

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 16, 2022

Description

This prevents nodes not specifically built for liquidators from running the inefficient liquidation_targets query.

closes: #827


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki requested a review from a team as a code owner September 16, 2022 06:32
@toteki toteki requested a review from a team as a code owner September 16, 2022 06:33
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to tell the value of LIQUIDATOR explicitly at make build and make install

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
RafilxTenfen and others added 2 commits September 16, 2022 07:13
Co-authored-by: Rafael Tenfen <rafaeltenfen.rt@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1395 (c13ed92) into main (844440c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   52.41%   52.44%   +0.02%     
==========================================
  Files          71       71              
  Lines        6799     6802       +3     
==========================================
+ Hits         3564     3567       +3     
  Misses       2966     2966              
  Partials      269      269              
Impacted Files Coverage Δ
x/leverage/keeper/grpc_query.go 64.17% <100.00%> (+0.54%) ⬆️

@mergify mergify bot merged commit dcd239b into main Sep 16, 2022
@mergify mergify bot deleted the adam/flag branch September 16, 2022 12:39
@robert-zaremba
Copy link
Member

Documentation is missing: both in the spec directory and release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/leverage: liquidation_targets query is inefficient
4 participants