fix: set 0 min gas prices #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @robert-zaremba / @brandoncomer |
|
how about the following:
|
Works for me, I'll convert to draft. Will bother infra about creating a new net for @brandoncomer on mon. |
|
On second thought, I don't think keplr will do this before we hit mainnet. @robert-zaremba @toteki can we please do this after v3? e: we've got to put this in, @toteki please check out tests while I work on the integrations 🙏 |
Codecov Report
@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
+ Coverage 52.52% 52.83% +0.31%
==========================================
Files 70 70
Lines 6692 6751 +59
==========================================
+ Hits 3515 3567 +52
- Misses 2909 2914 +5
- Partials 268 270 +2
|
toteki
reviewed
Sep 18, 2022
…/umee into woz/set-zero-min-gas-prices
|
lgtm except for the upgrade test failure (just can't approve my own PRs 😅) |
toteki
approved these changes
Sep 19, 2022
robert-zaremba
approved these changes
Sep 19, 2022
| @@ -63,7 +63,10 @@ func checkFees(minGasPrices sdk.DecCoins, fees sdk.Coins, gasLimit uint64) error | |||
| requiredFees[i] = sdk.NewCoin(gp.Denom, fee.Ceil().RoundInt()) | |||
| } | |||
|
|
|||
| if !fees.IsAnyGTE(requiredFees) { | |||
| // Clear any zero coins from requiredFees in the case of zero min gas price | |||
| requiredFees = sdk.NewCoins(requiredFees...) | |||
There was a problem hiding this comment.
this line is not needed - let's update the loop above:
requiredFees := make(sdk.Coins, len(minGasPrices), 0)
// Determine the required fees by multiplying each required minimum gas
// price by the gas limit, where fee = ceil(minGasPrice * gasLimit).
glDec := sdk.NewDec(int64(gasLimit))
for _, gp := range minGasPrices {
if gp.IsZero() || gasLimit == 0 {
continue
}
fee := gp.Amount.Mul(glDec)
requiredFees = append(requiredFees, sdk.NewCoin(gp.Denom, fee.Ceil().RoundInt()))
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is necessary for testing since keplr's suggestchain feature only allows default gas prices computations. We should add this in another prop after v3
This is initially opened for discussion
Update: Let's use this to build a network to test keplr against for the frontend team.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...