Skip to content

feat: Add crypto.com provider #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 5, 2022
Merged

feat: Add crypto.com provider #1448

merged 15 commits into from
Oct 5, 2022

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #1305


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari marked this pull request as ready for review October 3, 2022 14:25
@rbajollari rbajollari requested a review from a team as a code owner October 3, 2022 14:25
@rbajollari rbajollari force-pushed the ryan/add-crypto-provider branch from 984529b to 5d4f481 Compare October 3, 2022 19:29
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!! I know my first provider was not this clean in this repo lol

got a couple changes 🚀

Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closer @rbajollari 🚀

Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job @rbajollari

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the code looks great 💯

but I was testing with "ATOM_USDT" and received some errors that I think they are okay
image

But just to note, after some time the crypto provider still was giving

2:56PM WRN provider deviating from other candles base=ATOM module=oracle price=12.879940814866863791 provider=crypto

cc @adamewozniak

@rbajollari rbajollari merged commit 91ab9fc into main Oct 5, 2022
@rbajollari rbajollari deleted the ryan/add-crypto-provider branch October 5, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Price-feeder: add crypto.com provider
3 participants