-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(price-feeder): Convert remaining providers to the Websocket Controller #1554
Conversation
b15e1ca
to
132d95e
Compare
woo! Checking this out @zarazan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just need tests to pass.
would like another review, maybe from @rbajollari / @RafilxTenfen before we merge this in
oh, and changelog please! |
With this implementation, peggo cannot update the price-feeder version anymore, basically peggo does not know which prices will have to query when instantiating new providers. The new tickers might appear when someone tries to cross a different token Or maybe every time a new price comes, we would need to kill the providers and instantiate again |
this is so much cleaner than it was before, but thinking of price-feeder as a package for others, would be good to have an func to subscribe new pairs as needed with the provider running |
cc @zarazan |
the rest of the providers still need it
@zarazan please lmk once rafael's concerns are addressed 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, might want another review from @RafilxTenfen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Do these need to be backported for price feeder v1 branch or is it all v2 stuff? |
Description
Converted the remaining providers over to use the Websocket Controller. For each provider I cross referenced the current API docs with how we currently handle their websocket and tuned it to maintain a stable connection.
Changes other than just converting providers to use the Controller:
closes: #1507
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...