Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(price-feeder): Parse multiple candles from OsmosisV2 response #1615

Merged
merged 4 commits into from
Nov 22, 2022
Merged

fix(price-feeder): Parse multiple candles from OsmosisV2 response #1615

merged 4 commits into from
Nov 22, 2022

Conversation

zarazan
Copy link
Contributor

@zarazan zarazan commented Nov 22, 2022

Description

  • Fixes only old candle prices in the price-feeder for the OsmosisV2 API

closes: #87

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zarazan zarazan marked this pull request as ready for review November 22, 2022 18:23
@zarazan zarazan requested a review from a team as a code owner November 22, 2022 18:23
adamewozniak
adamewozniak approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@adamewozniak adamewozniak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (tACK) ! just one changelog nit

seems to work great with OSMO/ATOM 💯

@adamewozniak
Copy link
Collaborator

also @zarazan please remember to put in a backport label for api-compatible price-feeder fixes 🙏

@codecov-commenter
Copy link

Codecov Report

Merging #1615 (ee02716) into main (3650653) will decrease coverage by 0.40%.
The diff coverage is 26.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
- Coverage   55.47%   55.07%   -0.41%     
==========================================
  Files          68       68              
  Lines        6725     6825     +100     
==========================================
+ Hits         3731     3759      +28     
- Misses       2717     2785      +68     
- Partials      277      281       +4
Impacted Files Coverage Δ
x/oracle/types/keys.go 92.59% <ø> (ø)
x/oracle/types/msgs.go 87.36% <0.00%> (-2.85%) ⬇️
x/oracle/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/oracle/keeper/grpc_query.go 91.84% <69.23%> (-4.73%) ⬇️

@zarazan zarazan merged commit ce38df3 into main Nov 22, 2022
@zarazan zarazan deleted the zarazan/fix-osmov2-candles branch November 22, 2022 19:07
@mergify mergify bot mentioned this pull request Nov 22, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 22, 2022
@zarazan @mergify
fix(price-feeder): Parse multiple candles from OsmosisV2 response (#1615
f373119 
)

Parse an array of candle responses from osmosisV2 api

(cherry picked from commit ce38df3)
adamewozniak pushed a commit that referenced this pull request Nov 22, 2022
@mergify @zarazan
fix(price-feeder): Parse multiple candles from OsmosisV2 response (#1615
6cf79c0 
) (#1616)

Parse an array of candle responses from osmosisV2 api

(cherry picked from commit ce38df3)

Co-authored-by: Kyle Zarazan <zarazan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamewozniak adamewozniak adamewozniak approved these changes

Assignees
No one assigned
Labels
C:Price-Feeder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zarazan @adamewozniak @codecov-commenter