Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export genesis tracks reserves #1650

Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix: export genesis tracks reserves #1650

merged 2 commits into from
Dec 7, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Dec 7, 2022

Description

Conditions for bug:

  • Starting chain from exported genesis (i.e. hard fork)
  • Other genesis exports

Effects of bug:

  • If we ever do a hard fork, reserves accumulated from borrow interest would not carry over.
  • Other processes relying on exported genesis might arrive at a bad app hash due to disagreeing on state

This would essentially making it as if the reserve_factor had been zero instead of ~0.1 for all tokens:

  • slightly benefitting suppliers
  • but putting protocol bad debt repayment at risk

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki marked this pull request as ready for review December 7, 2022 21:23
@toteki toteki requested review from a team as code owners December 7, 2022 21:23
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me 🔥

might want to get a couple more approvals tho. feature creep is real

@robert-zaremba
Copy link
Member

So, in one sentence (or one line of code), Reserve is not set in the export.

@toteki toteki merged commit 36f103f into main Dec 7, 2022
@toteki toteki deleted the adam/genesis branch December 7, 2022 22:29
robert-zaremba pushed a commit that referenced this pull request Dec 20, 2022
* fix: export genesis tracks reserves

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants