-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update historic medians query #1651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where and why there was a decision to expose the aggregate methods outside? These can be expensive and should not be exposed by default.
Codecov Report
@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
+ Coverage 55.29% 55.34% +0.04%
==========================================
Files 73 73
Lines 7503 7511 +8
==========================================
+ Hits 4149 4157 +8
+ Misses 3034 3033 -1
- Partials 320 321 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm! we should rename the title of this PR though
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add min or max limit for numStamps
params , and can do make proto-all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@robert-zaremba please re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- regenerate proto based on updated types
- in ValidateBasic check that
numStamps > 0
and add a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicked too quickly, see my previous review.
cc @rbajollari |
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@robert-zaremba is there any reason to block this? let's get this merged in |
@adamewozniak yes, see my review. Especially the first one. Few important things were missing. going to do second review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...