-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: leverage.MaxBorrow return zero instead of failing when there is no more to borrow #1694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@robert-zaremba can you fix failing tests |
Codecov Report
@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
- Coverage 57.55% 57.53% -0.03%
==========================================
Files 75 75
Lines 7925 7928 +3
==========================================
Hits 4561 4561
- Misses 3014 3016 +2
- Partials 350 351 +1
|
A couple bits of cleanup, but looks good overall |
imo we should probably not scope creep this into v4 |
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we got everything - once that uToken check is hopefully added to queryMaxWithdraw, should be good to merge
Description
ref: #1690 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...