Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unit and e2e tests to ibc-quota #1738

Merged
merged 112 commits into from
Feb 2, 2023
Merged

test: unit and e2e tests to ibc-quota #1738

merged 112 commits into from
Feb 2, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Jan 23, 2023 •
edited
Loading

Description

Adding unit and e2e tests to ibc transfer quota
closes: #1742

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

gsk967 and others added 30 commits November 7, 2022 21:57
@gsk967
WIP: add ibc rate limit middleware to ibc transfer
6ed9e1f
@gsk967
Merge main
4ce49c9
@gsk967
WIP: add cll tx,query cmds
aada85f 
1. add cli queries for rate_limits and params
2. add updateProposal for rate_limits and ibcPause status
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
08e3d08
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
16b50cd
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
57870ca
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
8412c70
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
9a4d380
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
28e2422
@gsk967
WIP: add check rate limits for ibc denom
8e24765
@gsk967
remove ibc-rate-limits and move rate limits into ibctransfer module
4ad23eb
@gsk967
move the umme ibctransfer into ics20 folder
9bf0109
@gsk967
fix: fix the lint
a87ff0d
@gsk967
refactor: change the module structure to 'authz' type of cosmos-sdk
bdeaec3
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
aba25e0
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
7981d0d
@gsk967
remove inflow_limit in rate limits
37b15b3
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
ea1316e
@gsk967
Merge remote-tracking branch 'origin/sai/ibc-rate-limit' into sai/ibc…
ac8381c 
…-rate-limit
@gsk967
chore: check the rate limits by exchange rate
a8206d3
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
990db76
@gsk967
add denom exponent to calculate amount in USD
49c2bbb
@gsk967
calculating the sent amount with exponent of registerd token
b5435b1
@gsk967
fix: fix the amount calculation
3143115
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
db358cf
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
0b30201
@gsk967
Merge main
bce7a99
@gsk967
fix: fix the rate-limit reset issue
30bbdfc
@gsk967
Merge branch 'main' into sai/ibc-rate-limit
c2d0bc5
@gsk967
refactor: update the params
01ce260 
  1. add token_quota, total_quota, quota_duration params
  2. ibc-transfer token quota checking with token_quota and total_quota params
@gsk967 gsk967 changed the title test(DNM): unit and e2e tests to ibc-quota test: unit and e2e tests to ibc-quota Jan 30, 2023
@gsk967 gsk967 changed the base branch from sai/ibc-rate-limit to main January 30, 2023 17:08
@gsk967 gsk967 marked this pull request as ready for review January 30, 2023 17:08
@gsk967 gsk967 requested review from a team as code owners January 30, 2023 17:08
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 30, 2023
View reviewed changes
x/uibc/module/abci.go Fixed Show fixed Hide fixed
x/uibc/module/abci.go Fixed Show fixed Hide fixed
x/uibc/module/abci.go Fixed Show fixed Hide fixed
x/uibc/module/abci.go Fixed Show fixed Hide fixed
x/uibc/module/abci.go Fixed Show fixed Hide fixed
x/uibc/module/abci.go Fixed Show fixed Hide fixed
robert-zaremba
robert-zaremba reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's don't use testify/suite. We are ok to use testify/require if this helps.

x/uibc/client/tests/suite.go Outdated Show resolved Hide resolved
robert-zaremba
robert-zaremba reviewed Jan 31, 2023
View reviewed changes
x/uibc/msg_test.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/genesis_test.go Show resolved Hide resolved
robert-zaremba
robert-zaremba reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's convert all tests suites to gotest/tools/v3 based tests
  2. let's set t.Parallel() wherever possible.

Makefile Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
x/uibc/client/tests/cli_test.go Outdated Show resolved Hide resolved
x/uibc/client/tests/cli_test.go Outdated Show resolved Hide resolved
x/uibc/client/tests/query.go Show resolved Hide resolved
x/uibc/client/tests/query.go Show resolved Hide resolved
robert-zaremba
robert-zaremba approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving. Please look at all comments before merging

x/uibc/genesis_test.go Show resolved Hide resolved
x/uibc/msg.go Outdated Show resolved Hide resolved
x/uibc/msg_test.go Show resolved Hide resolved
x/uibc/msg_test.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/genesis_test.go Show resolved Hide resolved
x/uibc/quota/keeper/genesis_test.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/msg_server_test.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/msg_server_test.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/msg_server_test.go Show resolved Hide resolved
@gsk967 gsk967 merged commit 00c708d into main Feb 2, 2023
@gsk967 gsk967 deleted the sai/ibc_quota_test branch February 2, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
A:Automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add unit,cli and e2e tests for ibc quota
3 participants
@gsk967 @codecov-commenter @robert-zaremba