Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: testing guidelines #1744

Merged
merged 5 commits into from
Jan 25, 2023
Merged

docs: testing guidelines #1744

merged 5 commits into from
Jan 25, 2023

Conversation

robert-zaremba
Copy link
Member

Description

Adding testing guidelines

  • highlight the patterns and tools we should use more
  • highlight anti-patterns or practices we should use less
  • list tools which we currently use in the ecosystem.

The follow up will be to integrate mockgen with isolated integration test.

@robert-zaremba robert-zaremba requested review from a team as code owners January 24, 2023 20:02
zarazan
zarazan reviewed Jan 25, 2023
View reviewed changes
docs/testing.md Outdated Show resolved Hide resolved
zarazan
zarazan approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@zarazan zarazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating some of the info from the doc I made! I added a couple suggestions.

@mergify mergify bot merged commit f71f9ae into main Jan 25, 2023
@mergify mergify bot deleted the robert/testing-docs branch January 25, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toteki toteki toteki left review comments

@zarazan zarazan zarazan approved these changes

Assignees

@zarazan zarazan

@gsk967 gsk967

Labels
A:Automerge C:Docs T:Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robert-zaremba @zarazan @toteki @gsk967 @adamewozniak