Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move sdkutil coin functions to the coin package #1780

Merged
merged 8 commits into from
Feb 3, 2023
Merged

Conversation

robert-zaremba
Copy link
Member

Description

skdutil should be as small as possible.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added T:Test C:Core Core app features labels Feb 3, 2023
@robert-zaremba robert-zaremba requested a review from a team as a code owner February 3, 2023 16:58
@codecov-commenter
Copy link

Codecov Report

Merging #1780 (f5cac14) into main (f3125a6) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1780   +/-   ##
=======================================
  Coverage   57.69%   57.69%           
=======================================
  Files          78       78           
  Lines        8022     8022           
=======================================
  Hits         4628     4628           
  Misses       3053     3053           
  Partials      341      341           
Impacted Files Coverage Δ
x/leverage/keeper/keeper.go 69.27% <100.00%> (ø)
x/leverage/keeper/msg_server.go 79.06% <100.00%> (ø)

@gsk967 gsk967 changed the title chore: move skdutil coin functions to the coin package chore: move sdkutil coin functions to the coin package Feb 3, 2023
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move mkCoin func to New into coin package and use this New func instead of mkCoin over the testing

func New(denom string, amount int64) sdk.Coin {
    return sdk.NewInt64Coin(denom,amount)
}

@robert-zaremba
Copy link
Member Author

Move mkCoin func to New into coin package and use this New func instead of mkCoin over the testing

good idea

@robert-zaremba
Copy link
Member Author

moved mkCoin to coin.New

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ab8e7e0 into main Feb 3, 2023
@mergify mergify bot deleted the robert/coin branch February 3, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants