Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: currency provider tracker causing price feeder to error #1781

Merged
merged 13 commits into from
Feb 7, 2023

Conversation

rbajollari
Copy link
Contributor

@rbajollari rbajollari commented Feb 3, 2023

Description

closes: #1759

  • prevent collision of coin id to coin symbol in coinIDSymbolMap
  • don't stop the price feeder if coin gecko api request errors (log error and have minimum providers for the pair be 3)
  • take out btc in example config
  • change price-feeder timeout back to 1 minute in e2e test

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari marked this pull request as ready for review February 3, 2023 21:34
@rbajollari rbajollari requested review from a team as code owners February 3, 2023 21:34
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rethink the flow

price-feeder/price-feeder.example.toml Show resolved Hide resolved
price-feeder/config/currency_provider_tracker.go Outdated Show resolved Hide resolved
price-feeder/config/currency_provider_tracker.go Outdated Show resolved Hide resolved
price-feeder/config/currency_provider_tracker.go Outdated Show resolved Hide resolved
price-feeder/config/currency_provider_tracker.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving. Let's add missing docs: changelog, release notes, comment about the zero case for min providers...

price-feeder/price-feeder.example.toml Show resolved Hide resolved
@rbajollari rbajollari merged commit 89d2d3d into main Feb 7, 2023
@rbajollari rbajollari deleted the ryan/currency-tracker branch February 7, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currency Provider Tracker coinIDSymbolMap
3 participants