Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated use of sdkerrors #1788

Merged
merged 2 commits into from
Feb 7, 2023
Merged

fix: deprecated use of sdkerrors #1788

merged 2 commits into from
Feb 7, 2023

Conversation

robert-zaremba
Copy link
Member

Description

Fixes golangci-lint complains about usage of deprecated function

@robert-zaremba robert-zaremba requested review from a team as code owners February 6, 2023 21:56
@robert-zaremba
Copy link
Member Author

I will look at the failing tests tomorrow.

Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean PR

@codecov-commenter
Copy link

Codecov Report

Merging #1788 (7909e6d) into main (82f7716) will not change coverage.
The diff coverage is 39.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1788   +/-   ##
=======================================
  Coverage   57.83%   57.83%           
=======================================
  Files          78       78           
  Lines        8013     8013           
=======================================
  Hits         4634     4634           
  Misses       3043     3043           
  Partials      336      336           
Impacted Files Coverage Δ
x/leverage/keeper/keeper.go 69.27% <0.00%> (ø)
x/leverage/keeper/oracle.go 62.01% <0.00%> (ø)
x/leverage/types/genesis.go 10.58% <0.00%> (ø)
x/leverage/types/msgs.go 9.09% <0.00%> (ø)
x/leverage/types/token.go 78.98% <0.00%> (ø)
x/oracle/keeper/historic_price.go 60.89% <0.00%> (ø)
x/uibc/ics20/keeper/keeper.go 0.00% <0.00%> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <50.00%> (ø)
x/oracle/keeper/msg_server.go 64.70% <50.00%> (ø)
x/oracle/keeper/keeper.go 84.86% <80.00%> (ø)
... and 2 more

@mergify mergify bot merged commit 37909a3 into main Feb 7, 2023
@mergify mergify bot deleted the robert/fix-errors branch February 7, 2023 11:56
@rbajollari rbajollari mentioned this pull request Feb 9, 2023
17 tasks
@toteki
Copy link
Member

toteki commented Feb 14, 2023

@Mergifyio backport release/4.1.x

@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2023

backport release/4.1.x

❌ No backport have been created

  • Backport to branch release/4.1.x failed: Branch not found

@toteki
Copy link
Member

toteki commented Feb 14, 2023

@Mergifyio backport release/v4.1.x

mergify bot pushed a commit that referenced this pull request Feb 14, 2023
## Description

Fixes golangci-lint complains about usage of deprecated function

(cherry picked from commit 37909a3)

# Conflicts:
#	x/incentive/errors.go
#	x/leverage/keeper/oracle.go
#	x/oracle/types/errors.go
#	x/uibc/errors.go
#	x/uibc/msg.go
#	x/uibc/quota/ibc_module.go
#	x/uibc/quota/keeper/quota.go
#	x/uibc/quota/keeper/relay.go
@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2023

backport release/v4.1.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants