Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(price-feeder): Fix gate provider getCandlePrices #1791

Merged
merged 11 commits into from
Feb 8, 2023

Conversation

zarazan
Copy link
Contributor

@zarazan zarazan commented Feb 7, 2023

  • Fix the gate providers getCandlePrices function to use the correct currency pair string for the stored map of candles
  • Updates the price-feeder integration test to use our current sample config
  • Removes the noisy websocket send message logger - only log when subscription messages are sent (excludes heartbeat/ping messages)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zarazan zarazan force-pushed the zarazan/integration-endpoints branch from 4088780 to a70c642 Compare February 7, 2023 15:56
@zarazan zarazan changed the title test(price-feeder): Update integration test to parse custom provider endpoints fix(price-feeder): Fix gate provider getCandlePrices Feb 7, 2023
@zarazan zarazan force-pushed the zarazan/integration-endpoints branch from 26c5237 to 85cf387 Compare February 7, 2023 18:34
@zarazan zarazan marked this pull request as ready for review February 7, 2023 18:34
@zarazan zarazan requested a review from a team as a code owner February 7, 2023 18:34
Copy link
Contributor

@rbajollari rbajollari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@zarazan zarazan merged commit e753ad4 into main Feb 8, 2023
@zarazan zarazan deleted the zarazan/integration-endpoints branch February 8, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants