Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increasing unit tests coverage #1962

Merged
merged 19 commits into from
Apr 6, 2023
Merged

test: increasing unit tests coverage #1962

merged 19 commits into from
Apr 6, 2023

Conversation

kosegor
Copy link
Contributor

@kosegor kosegor commented Mar 29, 2023

Description

closes: #484


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1962 (faebe07) into main (b0f1cfb) will increase coverage by 6.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
+ Coverage   68.43%   75.38%   +6.95%     
==========================================
  Files         100      100              
  Lines        8021     8025       +4     
==========================================
+ Hits         5489     6050     +561     
+ Misses       2110     1589     -521     
+ Partials      422      386      -36     
Impacted Files Coverage Δ
x/leverage/types/msgs.go 100.00% <100.00%> (+90.90%) ⬆️
x/leverage/types/params.go 98.21% <100.00%> (+75.69%) ⬆️

... and 10 files with indirect coverage changes

@kosegor kosegor marked this pull request as ready for review April 4, 2023 14:23
@kosegor kosegor requested review from a team as code owners April 4, 2023 14:23
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - I left a couple comments but it should be good to merge overall

x/leverage/types/genesis_test.go Outdated Show resolved Hide resolved
x/leverage/types/genesis_test.go Show resolved Hide resolved
x/leverage/types/params_test.go Show resolved Hide resolved
x/uibc/quota/keeper/quota_test.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota_test.go Outdated Show resolved Hide resolved
x/uibc/quota/keeper/quota_test.go Show resolved Hide resolved
x/uibc/quota/keeper/quota_test.go Show resolved Hide resolved
@kosegor kosegor added this pull request to the merge queue Apr 6, 2023
Merged via the queue into main with commit 05a1d1b Apr 6, 2023
@kosegor kosegor deleted the egor/increase-coverage branch April 6, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/leverage: expand types.genesis_test.go
2 participants