Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add checks for duplicate symbol denoms for adding new tokens on leverage #1989

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Apr 12, 2023

Description

closes: #1883


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 requested a review from a team as a code owner April 12, 2023 11:37
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1989 (f6b4816) into main (7f05ad4) will increase coverage by 0.01%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1989      +/-   ##
==========================================
+ Coverage   75.38%   75.40%   +0.01%     
==========================================
  Files         100      100              
  Lines        8025     8029       +4     
==========================================
+ Hits         6050     6054       +4     
  Misses       1589     1589              
  Partials      386      386              
Impacted Files Coverage Δ
x/leverage/keeper/msg_server.go 78.91% <77.77%> (+0.05%) ⬆️
x/leverage/keeper/token.go 59.09% <80.00%> (+1.94%) ⬆️

@gsk967 gsk967 enabled auto-merge April 12, 2023 11:46
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog before merge

x/leverage/keeper/token.go Show resolved Hide resolved
@gsk967 gsk967 disabled auto-merge April 12, 2023 12:34
@gsk967 gsk967 requested a review from a team as a code owner April 12, 2023 12:36
@gsk967 gsk967 enabled auto-merge April 12, 2023 12:36
@gsk967 gsk967 added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit ff73a19 Apr 12, 2023
@gsk967 gsk967 deleted the sai/fix_duplicate_symbol_denom_tr branch April 12, 2023 12:55
@@ -76,6 +76,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
- [1954](https://github.com/umee-network/umee/pull/1954) Leverage: `MaxBorrow` now accounts for
`MinCollateralLiquidity` and `MaxSupplyUtilization`
- [1968](https://github.com/umee-network/umee/pull/1968) Leverage: fix type cast of AdjustedBorrow in ExportGenesis
- [1989](https://github.com/umee-network/umee/pull/1989) Leverage: fix the duplicate symbol denoms issue on adding new tokens to registry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong line. It should be in "Improvements" under unreleased.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix duplicate SYMBOL_DENOM in Update_Registry Proposal
3 participants