-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the custom handlers for cosmwasm #1997
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1997 +/- ##
==========================================
- Coverage 75.38% 70.58% -4.81%
==========================================
Files 100 126 +26
Lines 8025 9580 +1555
==========================================
+ Hits 6050 6762 +712
- Misses 1589 2352 +763
- Partials 386 466 +80
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Be sure to use the var names name consistent with message name for MsgSupplyCollateral
)
A question:
Do these handlers carry any risk of bypassing GetSigners
security? For example, the rule where MsgSupply.Supplier
field must be the same address that signed it
It should not bypass the signer's rule, it is the same as sending a msg through the leverage |
* tests: add cw20 testing on cosmwasm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's check if there is other way than the big ambiguous JSON. I indicated already half a year ago, but didn't a good example. Osmosis is also using this style. It works, so not blocking, but let's find out if there is no better way before merging.
Description
closes: #XXXX
Test the cosmwasm
Build the binary from
build
(from this branch:sai/wasm_handler
https://github.com/umee-network/umee/tree/sai/wasm_handler)Clone the umee-infra repo
Copy the binary to umee-infra (./noob/umeed-builds/umeed-cosmwasm)
Setup the multi node with cosmwasm
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...