Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better upgrade registration #2024

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

robert-zaremba
Copy link
Member

Added an util function to simplify upgrade registration even more.

@robert-zaremba robert-zaremba requested a review from a team as a code owner May 5, 2023 17:43
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #2024 (259bd52) into main (7f05ad4) will decrease coverage by 6.88%.
The diff coverage is 45.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
- Coverage   75.38%   68.51%   -6.88%     
==========================================
  Files         100      118      +18     
  Lines        8025     9349    +1324     
==========================================
+ Hits         6050     6405     +355     
- Misses       1589     2469     +880     
- Partials      386      475      +89     
Impacted Files Coverage Δ
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/keeper/incentive.go 0.00% <0.00%> (ø)
x/oracle/keeper/hooks.go 95.65% <ø> (ø)
x/uibc/quota/keeper/ics4_wrapper.go 0.00% <ø> (ø)
x/incentive/keeper/genesis.go 1.61% <1.61%> (ø)
x/incentive/genesis.go 10.32% <3.70%> (-3.01%) ⬇️
... and 30 more

... and 2 files with indirect coverage changes

@robert-zaremba robert-zaremba enabled auto-merge May 5, 2023 20:08
@robert-zaremba robert-zaremba added this pull request to the merge queue May 5, 2023
Merged via the queue into main with commit 855fc06 May 5, 2023
@robert-zaremba robert-zaremba deleted the robert/simplify-upgrades branch May 5, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants