Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow collateral weight = liquidation threshold #2052

Merged
merged 6 commits into from
May 19, 2023
Merged

Conversation

toteki
Copy link
Member

@toteki toteki commented May 18, 2023

Previously #1956 prevented this, but this has made tokens with collateral weight = liquidation threshold = 0 invalid, including some in the existing mainnet registry.

@toteki toteki requested a review from a team as a code owner May 18, 2023 17:07
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #2052 (862cffb) into main (7f05ad4) will decrease coverage by 4.90%.
The diff coverage is 58.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2052      +/-   ##
==========================================
- Coverage   75.38%   70.49%   -4.90%     
==========================================
  Files         100      126      +26     
  Lines        8025     9605    +1580     
==========================================
+ Hits         6050     6771     +721     
- Misses       1589     2367     +778     
- Partials      386      467      +81     
Impacted Files Coverage Δ
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/keeper/incentive.go 0.00% <0.00%> (ø)
x/oracle/keeper/hooks.go 95.65% <ø> (ø)
x/ugov/keeper/msg_server.go 0.00% <0.00%> (ø)
x/ugov/keeper/query_server.go 0.00% <0.00%> (ø)
x/uibc/quota/keeper/genesis.go 0.00% <0.00%> (-100.00%) ⬇️
x/uibc/quota/keeper/grpc_query.go 0.00% <0.00%> (-76.93%) ⬇️
... and 46 more

... and 2 files with indirect coverage changes

toteki and others added 2 commits May 18, 2023 17:56
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@toteki toteki requested a review from a team as a code owner May 18, 2023 23:58
@toteki toteki enabled auto-merge May 18, 2023 23:58
@toteki toteki added this pull request to the merge queue May 19, 2023
Merged via the queue into main with commit 3bb9801 May 19, 2023
@toteki toteki deleted the adam/fixlt branch May 19, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants