feat: add inspector queries #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2085 +/- ##
==========================================
- Coverage 75.38% 74.89% -0.49%
==========================================
Files 100 127 +27
Lines 8025 9745 +1720
==========================================
+ Hits 6050 7299 +1249
- Misses 1589 1963 +374
- Partials 386 483 +97
|
This reverts commit 402c325.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
toteki
commented
Jun 6, 2023
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
|
See updated PR description for examples of new CLI and web usage |
| for _, account := range borrowers { | ||
| ok := account.Analysis.Borrowed > req.Borrowed | ||
| ok = ok && account.Analysis.Value > req.Collateral | ||
| ok = ok && account.Analysis.Borrowed/account.Analysis.Liquidation > req.Danger |
Check notice
Code scanning / CodeQL
Floating point arithmetic
| ok := account.Analysis.Borrowed > req.Borrowed | ||
| ok = ok && account.Analysis.Value > req.Collateral | ||
| ok = ok && account.Analysis.Borrowed/account.Analysis.Liquidation > req.Danger | ||
| ok = ok && account.Analysis.Borrowed/account.Analysis.Value > req.Ltv |
Check notice
Code scanning / CodeQL
Floating point arithmetic
| } | ||
| // Truncate the float at a certain precision (can be negative) | ||
| x := math.Pow(10, float64(precision)) | ||
| return float64(int(n*x)) / x |
Check notice
Code scanning / CodeQL
Floating point arithmetic
| } | ||
| // Truncate the float at a certain precision (can be negative) | ||
| x := math.Pow(10, float64(precision)) | ||
| return float64(int(n*x)) / x |
Check notice
Code scanning / CodeQL
Floating point arithmetic
robert-zaremba
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a query that combines the risk data query as specified by risk team, and the inspector query which allows a user to filter all active borrower accounts.
umeed query leverage inspect [symbol] [borrowed] [collateral [danger] [ltv]Example of web usage:
Example of new CLI usage:
(show all borroweds with
>$100k USD borrowed valueand>0.7 LTV