Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flash liquidation proto #2102

Merged
merged 12 commits into from
Jun 22, 2023
Merged

feat: flash liquidation proto #2102

merged 12 commits into from
Jun 22, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Jun 21, 2023 •
edited
Loading

Proto (and scaffolding around generated framework) only in this PR.

@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #2102 (5ec8bb3) into main (7f05ad4) will decrease coverage by 0.78%.
The diff coverage is 79.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
- Coverage   75.38%   74.61%   -0.78%     
==========================================
  Files         100      127      +27     
  Lines        8025     9805    +1780     
==========================================
+ Hits         6050     7316    +1266     
- Misses       1589     2004     +415     
- Partials      386      485      +99
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/keeper.go 64.28% <ø> (ø)
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
x/leverage/keeper/grpc_query.go 67.21% <ø> (ø)
x/leverage/keeper/hooks.go 42.85% <ø> (ø)
... and 67 more

... and 24 files with indirect coverage changes

@toteki toteki changed the title feat: add flash liquidation feat: flash liquidation proto Jun 21, 2023
@toteki toteki marked this pull request as ready for review June 21, 2023 12:53
@toteki toteki requested a review from a team as a code owner June 21, 2023 12:53
gsk967
gsk967 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@gsk967 gsk967 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left some comments, Please check those and resolve lint issues

robert-zaremba
robert-zaremba approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pre-approving.

  • I would prefer to discuss a different name for the rpc method (see the comment)
  • changelog update is missing

@toteki toteki requested a review from a team as a code owner June 22, 2023 03:58
@toteki toteki added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit 11e720a Jun 22, 2023
@toteki toteki deleted the adam/flashliq branch June 22, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@gsk967 gsk967 gsk967 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toteki @robert-zaremba @gsk967