Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new token emission #2145

Merged
merged 33 commits into from
Jul 26, 2023
Merged

feat: new token emission #2145

merged 33 commits into from
Jul 26, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Jul 13, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #2145 (3cbf87e) into main (7f05ad4) will decrease coverage by 5.16%.
Report is 150 commits behind head on main.
The diff coverage is 80.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
- Coverage   75.38%   70.23%   -5.16%     
==========================================
  Files         100      148      +48     
  Lines        8025    11319    +3294     
==========================================
+ Hits         6050     7950    +1900     
- Misses       1589     2824    +1235     
- Partials      386      545     +159     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/unbonding.go 80.45% <ø> (ø)
x/incentive/keeper/update.go 52.11% <ø> (ø)
x/incentive/keys.go 100.00% <ø> (ø)
x/incentive/msgs.go 77.41% <ø> (-0.81%) ⬇️
x/incentive/params.go 89.28% <ø> (-10.72%) ⬇️
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <ø> (ø)
... and 54 more

... and 54 files with indirect coverage changes

x/mint/module/abci.go Fixed Show fixed Hide fixed
x/mint/module/abci.go Fixed Show fixed Hide fixed
x/mint/module/abci.go Fixed Show fixed Hide fixed
x/mint/module/abci.go Fixed Show fixed Hide fixed
x/mint/module/module.go Fixed Show fixed Hide fixed
@gsk967 gsk967 marked this pull request as ready for review July 17, 2023 08:20
@gsk967 gsk967 requested a review from a team as a code owner July 17, 2023 08:20
@gsk967 gsk967 changed the title feat(WIP): new token emission feat: new token emission Jul 17, 2023
x/mint/abci.go Fixed Show fixed Hide fixed
x/mint/abci.go Fixed Show fixed Hide fixed
x/mint/abci.go Fixed Show fixed Hide fixed
x/mint/abci.go Fixed Show fixed Hide fixed
x/mint/module.go Fixed Show fixed Hide fixed
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's consider using basis points for efficiency.
in proto it will be

  uint32 inflation_reduction_rate = 3 [(gogoproto.customtype) = "github.com/umee-network/umee/util/bpmath.FixedBP"  ];

Will review the x/mint logic later

proto/umee/ugov/v1/genesis.proto Outdated Show resolved Hide resolved
proto/umee/ugov/v1/query.proto Outdated Show resolved Hide resolved
proto/umee/ugov/v1/ugov.proto Outdated Show resolved Hide resolved
proto/umee/ugov/v1/ugov.proto Outdated Show resolved Hide resolved
x/ugov/inflation_params.go Outdated Show resolved Hide resolved
x/ugov/keeper/keys.go Outdated Show resolved Hide resolved
x/ugov/keeper/params.go Outdated Show resolved Hide resolved
x/ugov/keeper/params.go Outdated Show resolved Hide resolved
x/ugov/keeper/params_test.go Outdated Show resolved Hide resolved
x/ugov/msg.go Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add changelog
  • [ ]

proto/umee/ugov/v1/genesis.proto Outdated Show resolved Hide resolved
proto/umee/ugov/v1/query.proto Outdated Show resolved Hide resolved
proto/umee/ugov/v1/query.proto Outdated Show resolved Hide resolved
x/mint/abci.go Outdated Show resolved Hide resolved
x/mint/abci.go Outdated Show resolved Hide resolved
x/mint/abci.go Outdated Show resolved Hide resolved
x/umint/abci.go Fixed Show fixed Hide fixed
x/umint/abci.go Fixed Show fixed Hide fixed
x/umint/abci.go Fixed Show fixed Hide fixed
x/umint/abci.go Fixed Show fixed Hide fixed
x/umint/module.go Fixed Show fixed Hide fixed
proto/umee/ugov/v1/events.proto Outdated Show resolved Hide resolved
proto/umee/ugov/v1/tx.proto Outdated Show resolved Hide resolved
proto/umee/ugov/v1/query.proto Outdated Show resolved Hide resolved
x/ugov/keeper/keys.go Outdated Show resolved Hide resolved
x/umint/abci.go Outdated Show resolved Hide resolved
x/umint/abci.go Outdated Show resolved Hide resolved
@robert-zaremba robert-zaremba mentioned this pull request Jul 21, 2023
17 tasks
x/umint/module.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for time storage, let's use store.SetTimeMs

x/ugov/keeper/params.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review

app/inflation/inflatin.go Outdated Show resolved Hide resolved
app/inflation/inflation.go Outdated Show resolved Hide resolved
app/inflation/inflation.go Outdated Show resolved Hide resolved
app/inflation/inflation.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there , few tiny improvements

app/inflation/inflation.go Outdated Show resolved Hide resolved
app/inflation/inflation.go Outdated Show resolved Hide resolved
app/inflation/inflation.go Outdated Show resolved Hide resolved
app/inflation/inflation.go Show resolved Hide resolved
app/inflation/inflation.go Outdated Show resolved Hide resolved
x/ugov/inflation_params.go Outdated Show resolved Hide resolved
x/ugov/inflation_params.go Outdated Show resolved Hide resolved
x/ugov/inflation_params.go Outdated Show resolved Hide resolved
x/ugov/keeper/keys.go Outdated Show resolved Hide resolved
x/ugov/keeper/params_test.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsk967 gsk967 added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit caedf18 Jul 26, 2023
@gsk967 gsk967 deleted the sai/token_emission branch July 26, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants