Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor 5.2 message fixes #2148

Merged
merged 8 commits into from
Jul 20, 2023
Merged

fix: minor 5.2 message fixes #2148

merged 8 commits into from
Jul 20, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Jul 17, 2023

  • MsgBeginUnbond max amount calculation (not currently affecting mainnet due to zero incentive unbonding period)
  • MsgLeveragedLiquidate CLI was not accepting empty denoms

@toteki toteki requested review from a team as code owners July 17, 2023 12:45
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #2148 (0305763) into main (7f05ad4) will decrease coverage by 0.87%.
The diff coverage is 77.79%.

❗ Current head 0305763 differs from pull request most recent head b802609. Consider uploading reports for the commit b802609 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   75.38%   74.52%   -0.87%     
==========================================
  Files         100      127      +27     
  Lines        8025     9981    +1956     
==========================================
+ Hits         6050     7438    +1388     
- Misses       1589     2039     +450     
- Partials      386      504     +118     
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <ø> (ø)
x/leverage/keeper/borrows.go 75.93% <ø> (-2.64%) ⬇️
x/leverage/keeper/collateral.go 72.72% <ø> (-0.16%) ⬇️
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
... and 60 more

... and 29 files with indirect coverage changes

CHANGELOG.md Show resolved Hide resolved
x/leverage/types/tx.go Outdated Show resolved Hide resolved
x/leverage/types/tx.go Outdated Show resolved Hide resolved
x/incentive/keeper/msg_server.go Show resolved Hide resolved
toteki and others added 3 commits July 18, 2023 07:29
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label Jul 20, 2023
@robert-zaremba robert-zaremba added this pull request to the merge queue Jul 20, 2023
Merged via the queue into main with commit a8400a7 Jul 20, 2023
@robert-zaremba robert-zaremba deleted the adam/fix branch July 20, 2023 14:37
robert-zaremba added a commit that referenced this pull request Aug 30, 2023
* fix: minor 5.2 fixes

* CL++

* test++

* lint++

* Update x/leverage/types/tx.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update x/leverage/types/tx.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

---------

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants