-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add special asset pairs #2150
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2150 +/- ##
==========================================
- Coverage 75.38% 68.86% -6.52%
==========================================
Files 100 151 +51
Lines 8025 11680 +3655
==========================================
+ Hits 6050 8044 +1994
- Misses 1589 3095 +1506
- Partials 386 541 +155
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- need to remove title and description from gov messages
- let's talk about using list of assets rather than a pair.
- use store helpers
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, adding some minor comments.
Co-authored-by: kosegor <30661385+kosegor@users.noreply.github.com>
Co-authored-by: kosegor <30661385+kosegor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Instead of simplifying user interface by using sets, this iteration added additional complexity to add both pairs and sets. Moreover the the pars are stored in each direction. So for a set
(A,B,C)
we store 6 pairs (and return 6 pairs when querying it, instead of 1):(A,B)
,(A,C)
,(B,C)
,(B,A),
(B,C),
(C,B)` -- that is against what we wanted based on the discussion in Slack. - if under the hood we save sets as pairs, then we need to rethink the key structure and assure we don't have duplicates.
- let's don't create new error codes, which are already deprecated.
- prefer to not use
yaml
- let's make sure we have unit-tests task in the Linear.
Contains logic for creating and storing these pairs, but not their actual effects on borrow limit.
These can be released early to accelerate their proposal timeline.