-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: basis points math package #2155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2155 +/- ##
==========================================
- Coverage 75.38% 74.71% -0.68%
==========================================
Files 100 129 +29
Lines 8025 10002 +1977
==========================================
+ Hits 6050 7473 +1423
- Misses 1589 2025 +436
- Partials 386 504 +118
|
gsk967
approved these changes
Jul 19, 2023
toteki
reviewed
Jul 19, 2023
toteki
reviewed
Jul 19, 2023
toteki
reviewed
Jul 19, 2023
toteki
reviewed
Jul 19, 2023
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
kosegor
approved these changes
Jul 19, 2023
toteki
reviewed
Jul 19, 2023
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New package to optimize arithmetic computation when we need to deal with fraction number of basis points.
There is no precision lost for operations like
a * b
wherea
orb
is basis points, and the other variable isInt
.