feat: add SupplyFromModule and WithdrawFromModule to leverage #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: @kosegor could you regenerate the mock keepers using whichever mock gen you used originally? I changed the leverage keeper's signature. |
robert-zaremba
approved these changes
Jul 27, 2023
pushed regenerated mocks |
kosegor
approved these changes
Jul 27, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
* reserves and interest refeactored * tests adapted (not working yet) * endblock funcs * Update x/metoken/keeper/redeem.go Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> * adam comments * fix mocks * safeguard for transferring dust * robert comments * fix * safer exit when asset not found * imports * feat: add SupplyFromModule and WithdrawFromModule to leverage (#2170) * add module-based supply and withdraw to leverage module * cl++ * change return order * godoc++ and function order * mocks * mocks --------- Co-authored-by: Egor Kostetskiy <kosegor@gmail.com> * new integration with x/leverage * fix after merge from main * unit mocks * fix * better logs * couple more comments --------- Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be merged into the metoken endblocker branch
It allows created
SupplyFromModuleandWithdrawFromModulewhich distinguish recoverable from nonrecoverable errors, and allows module-specific logic to be used in these functions in the future.