-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): replace nhooyr.io/websocket #2653
Conversation
WalkthroughThe pull request involves modifications to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (1)go.mod (1)
The replacement of
Consider documenting this dependency change in the project's documentation to help other developers understand why this replacement was necessary and any potential implications for future updates. ✅ Verification successfulBased on the results, I can now provide a final response as we have sufficient information about the fork's status and version changes: Fork replacement is verified and safe to use The replacement of
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the websocket package replacement
# Check the fork's status
echo "Checking fork status..."
gh repo view github.com/coder/websocket --json createdAt,updatedAt,isArchived,defaultBranchRef
# Check for breaking changes between versions
echo "Checking for breaking changes..."
gh api graphql -f query='
{
repository(owner: "coder", name: "websocket") {
releases(first: 10) {
nodes {
name
tagName
description
createdAt
}
}
}
}'
# Check usage patterns to ensure compatibility
echo "Checking usage patterns..."
rg -A 2 "websocket\." --type go
Length of output: 8730 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2653 +/- ##
===========================================
- Coverage 75.38% 61.97% -13.42%
===========================================
Files 100 275 +175
Lines 8025 19643 +11618
===========================================
+ Hits 6050 12174 +6124
- Misses 1589 6693 +5104
- Partials 386 776 +390 |
Description
nhooyr.io/websocket is not available any more, and github repo should be used.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit