Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update x/leverage messages codec #612

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

Add missing message types to codec registration.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez
Copy link
Contributor Author

Just an FYI @toteki -- when we add a new message type, we have to be sure to update codec.go 👍

@codecov-commenter
Copy link

Codecov Report

Merging #612 (ed02375) into main (c646ad7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   48.44%   48.47%   +0.02%     
==========================================
  Files          63       63              
  Lines        7932     7936       +4     
==========================================
+ Hits         3843     3847       +4     
  Misses       3831     3831              
  Partials      258      258              
Impacted Files Coverage Δ
x/leverage/types/codec.go 48.00% <100.00%> (+9.90%) ⬆️

@alexanderbez alexanderbez merged commit 7a8ded1 into main Mar 7, 2022
@alexanderbez alexanderbez deleted the bez/leverage-codec-updates branch March 7, 2022 14:40
mergify bot pushed a commit that referenced this pull request Mar 7, 2022
alexanderbez added a commit that referenced this pull request Mar 7, 2022
(cherry picked from commit 7a8ded1)

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants