-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: price-feeder: telemetry additions #673
Conversation
"type", | ||
"ticker", | ||
"provider", | ||
config.ProviderBinance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just using the only constants that carry the names of the providers here - maybe we should have an additional set of constants in the providers
package, but that seems a bit overkill for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also like @RafilxTenfen 's input on any other metrics that might be useful
The telemetry is going to increase the count when peggo uses the price-feeder? |
What do you think about adding telemetry to
|
iirc it would only count if telemetry were enabled (e.g. if you called |
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
Looks good (but give it a final check before merging) |
* add telemetry for websocket reconnection attempts & receiving candles / ticker messages * add "missed vote" telemetry * fix telemetry src * add a telemetry counter for subscriptions to cps * Update price-feeder/oracle/provider/gate.go Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> * Update price-feeder/oracle/provider/huobi.go Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> * Batch of 3 Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> (cherry picked from commit 0c65084)
* add telemetry for websocket reconnection attempts & receiving candles / ticker messages * add "missed vote" telemetry * fix telemetry src * add a telemetry counter for subscriptions to cps * Update price-feeder/oracle/provider/gate.go Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> * Update price-feeder/oracle/provider/huobi.go Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> * Batch of 3 Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> (cherry picked from commit 0c65084) Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Description
Adds some measurements for Websocket reconnection attempts & candle / ticker messages being received
closes: #637
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change