-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump github.com/spf13/cobra from 1.3.0 to 1.4.0 in /price-feeder (backport #639) #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-feeder (#639) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.3.0 to 1.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spf13/cobra/releases">github.com/spf13/cobra's releases</a>.</em></p> <blockquote> <h2>v1.4.0</h2> <h1>Winter 2022 Release ❄️</h1> <p>Another season, another release!</p> <h2>Goodbye viper! 🐍 🚀</h2> <p>The core Cobra library no longer requires Viper and all of its indirect dependencies. This means that Cobra's dependency tree has been drastically thinned! The Viper dependency was included because of the <code>cobra</code> CLI generation tool. <a href="https://github.com/spf13/cobra-cli/releases/tag/v1.3.0">This tool has migrated to <code>spf13/cobra-cli</code></a>.</p> <p>It's <em>pretty unlikely</em> you were importing and using <strong>the bootstrapping CLI tool</strong> as part of your application (after all, it's just a tool to get going with core <code>cobra</code>).</p> <p>But if you were, replace occurrences of</p> <pre><code>"github.com/spf13/cobra/cobra" </code></pre> <p>with</p> <pre><code>"github.com/spf13/cobra-cli" </code></pre> <p>And in your <code>go.mod</code>, you'll want to also include this dependency:</p> <pre><code>github.com/spf13/cobra-cli v1.3.0 </code></pre> <p>Again, the maintainers <em>do not anticipate</em> this being a breaking change to users of the core <code>cobra</code> library, so minimal work should be required for users to integrate with this new release. Moreover, this means the dependency tree for your application using Cobra should no longer require dependencies that were inherited from Viper. Huzzah! 🥳</p> <p>If you'd like to read more</p> <ul> <li>issue: <a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1597">spf13/cobra#1597</a></li> <li>PR: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1604">spf13/cobra#1604</a></li> </ul> <h2>Documentation 📝</h2> <ul> <li>Update Go Doc link and badge in README: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1593">spf13/cobra#1593</a></li> <li>Fix to install command, now targets <code>@latest</code>: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1576">spf13/cobra#1576</a></li> <li>Added MAINTAINERS file: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1545">spf13/cobra#1545</a></li> </ul> <h2>Other 💭</h2> <ul> <li>Bumped license year to 2022 in golden files: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1575">spf13/cobra#1575</a></li> <li>Added Pixie to projects: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1581">spf13/cobra#1581</a></li> <li>Updated labeler for new labeling scheme: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1613">spf13/cobra#1613</a> & syntax fix: <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1624">spf13/cobra#1624</a></li> </ul> <p>Shoutout to our awesome contributors helping to make this cobra release possible!! <a href="https://github.com/spf13"><code>@spf13</code></a> <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> <a href="https://github.com/johnSchnake"><code>@johnSchnake</code></a> <a href="https://github.com/jpmcb"><code>@jpmcb</code></a> <a href="https://github.com/liggitt"><code>@liggitt</code></a> <a href="https://github.com/umarcor"><code>@umarcor</code></a> <a href="https://github.com/hiljusti"><code>@hiljusti</code></a> <a href="https://github.com/marians"><code>@marians</code></a> <a href="https://github.com/shyim"><code>@shyim</code></a> <a href="https://github.com/htroisi"><code>@htroisi</code></a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/spf13/cobra/blob/master/CHANGELOG.md">github.com/spf13/cobra's changelog</a>.</em></p> <blockquote> <h1>Cobra Changelog</h1> <h2>v1.1.3</h2> <ul> <li><strong>Fix:</strong> release-branch.cobra1.1 only: Revert "Deprecate Go < 1.14" to maintain backward compatibility</li> </ul> <h2>v1.1.2</h2> <h3>Notable Changes</h3> <ul> <li>Bump license year to 2021 in golden files (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1309">#1309</a>) <a href="https://github.com/Bowbaq"><code>@Bowbaq</code></a></li> <li>Enhance PowerShell completion with custom comp (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1208">#1208</a>) <a href="https://github.com/Luap99"><code>@Luap99</code></a></li> <li>Update gopkg.in/yaml.v2 to v2.4.0: The previous breaking change in yaml.v2 v2.3.0 has been reverted, see <a href="https://github-redirect.dependabot.com/go-yaml/yaml/issues/670">go-yaml/yaml#670</a></li> <li>Documentation readability improvements (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1228">#1228</a> etc.) <a href="https://github.com/zaataylor"><code>@zaataylor</code></a> etc.</li> <li>Use golangci-lint: Repair warnings and errors resulting from linting (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1044">#1044</a>) <a href="https://github.com/umarcor"><code>@umarcor</code></a></li> </ul> <h2>v1.1.1</h2> <ul> <li><strong>Fix:</strong> yaml.v2 2.3.0 contained a unintended breaking change. This release reverts to yaml.v2 v2.2.8 which has recent critical CVE fixes, but does not have the breaking changes. See <a href="https://github-redirect.dependabot.com/spf13/cobra/pull/1259">spf13/cobra#1259</a> for context.</li> <li><strong>Fix:</strong> correct internal formatting for go-md2man v2 (which caused man page generation to be broken). See <a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1049">spf13/cobra#1049</a> for context.</li> </ul> <h2>v1.1.0</h2> <h3>Notable Changes</h3> <ul> <li>Extend Go completions and revamp zsh comp (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1070">#1070</a>)</li> <li>Fix man page doc generation - no auto generated tag when <code>cmd.DisableAutoGenTag = true</code> (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1104">#1104</a>) <a href="https://github.com/jpmcb"><code>@jpmcb</code></a></li> <li>Add completion for help command (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1136">#1136</a>)</li> <li>Complete subcommands when TraverseChildren is set (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1171">#1171</a>)</li> <li>Fix stderr printing functions (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/894">#894</a>)</li> <li>fix: fish output redirection (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1247">#1247</a>)</li> </ul> <h2>v1.0.0</h2> <p>Announcing v1.0.0 of Cobra. 🎉</p> <h3>Notable Changes</h3> <ul> <li>Fish completion (including support for Go custom completion) <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a></li> <li>API (urgent): Rename BashCompDirectives to ShellCompDirectives <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a></li> <li>Remove/replace SetOutput on Command - deprecated <a href="https://github.com/jpmcb"><code>@jpmcb</code></a></li> <li>add support for autolabel stale PR <a href="https://github.com/xchapter7x"><code>@xchapter7x</code></a></li> <li>Add Labeler Actions <a href="https://github.com/xchapter7x"><code>@xchapter7x</code></a></li> <li>Custom completions coded in Go (instead of Bash) <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a></li> <li>Partial Revert of <a href="https://github-redirect.dependabot.com/spf13/cobra/issues/922">#922</a> <a href="https://github.com/jharshman"><code>@jharshman</code></a></li> <li>Add Makefile to project <a href="https://github.com/jharshman"><code>@jharshman</code></a></li> <li>Correct documentation for InOrStdin <a href="https://github.com/desponda"><code>@desponda</code></a></li> <li>Apply formatting to templates <a href="https://github.com/jharshman"><code>@jharshman</code></a></li> <li>Revert change so help is printed on stdout again <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a></li> <li>Update md2man to v2.0.0 <a href="https://github.com/pdf"><code>@pdf</code></a></li> <li>update viper to v1.4.0 <a href="https://github.com/umarcor"><code>@umarcor</code></a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/spf13/cobra/commit/5b2b9e9f61d36ccb66167301f76a2292c3729855"><code>5b2b9e9</code></a> Removes viper dependency by removing cobra/ CLI tool (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1604">#1604</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/9369465955fcc766aed3e7cf574277ee553251d4"><code>9369465</code></a> labeler: fix syntax</li> <li><a href="https://github.com/spf13/cobra/commit/e1b831e5c2a1639f3bba57d0922fd0c7a7816df7"><code>e1b831e</code></a> Updates labeler for new labels (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1613">#1613</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/8267283cfe84768a0ec01b29b981f37e2ea99299"><code>8267283</code></a> Add MAINTAINERS file (alphabetical order) (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1545">#1545</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/6d2dc43606da38b673801b8f678c7e5143dfad58"><code>6d2dc43</code></a> Add Pixie to projects. (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1581">#1581</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/a5996323794c96a0d14df49f6675708a87e53b98"><code>a599632</code></a> Fix install command (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1576">#1576</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/7cabfeb8f837c7bd5b834f4fbe98fdef1136465a"><code>7cabfeb</code></a> Update Go Doc link and badge (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1593">#1593</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/e04ec725508c760e70263b031e5697c232d5c3fa"><code>e04ec72</code></a> Bump license year to 2022 in golden files (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1575">#1575</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/cb9d7b1cec87c2bb005c6e2790553bcd629bc542"><code>cb9d7b1</code></a> Bump github.com/spf13/viper from 1.10.0 to 1.10.1 (<a href="https://github-redirect.dependabot.com/spf13/cobra/issues/1567">#1567</a>)</li> <li>See full diff in <a href="https://github.com/spf13/cobra/compare/v1.3.0...v1.4.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/spf13/cobra&package-manager=go_modules&previous-version=1.3.0&new-version=1.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> (cherry picked from commit 5e86813)
mergify
bot
requested review from
toteki,
adamewozniak and
facundomedica
as code owners
March 25, 2022 07:19
toteki
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No e2e failure here (unlike #698) so it can go through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #639 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com