Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: v2 module replace #754

Merged
merged 7 commits into from
Apr 6, 2022
Merged

chore: v2 module replace #754

merged 7 commits into from
Apr 6, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Apr 5, 2022

Replaces umee go.mod path and imported path to include v2.

Compare to osmosis v7 go.mod and import paths

Ref: How to upgrade to a major version in Go

@toteki
Copy link
Member Author

toteki commented Apr 5, 2022

Note: price-feeder import paths still need to be figured out.

@toteki
Copy link
Member Author

toteki commented Apr 5, 2022 •
edited
Loading

Also note: doing the following in proto files causes unexpected behavior in make proto-gen. Looking into it.

option go_package = "github.com/umee-network/umee/v2/x/leverage/types";

edit: fixed output folder, see the script change in contrib

@toteki
Copy link
Member Author

toteki commented Apr 6, 2022

How many files would you like to change?

Yes.

@toteki toteki marked this pull request as ready for review April 6, 2022 10:55
@toteki toteki requested a review from a team as a code owner April 6, 2022 10:55
@toteki toteki merged commit ed28fdc into main Apr 6, 2022
@toteki toteki deleted the adam/v2 branch April 6, 2022 15:37
mergify bot pushed a commit that referenced this pull request Apr 6, 2022
@toteki
chore: v2 module replace (#754)
e659dad 
* all replaces EXCEPT in price feeder

* fix make proto-gen output folder to allow major versions

(cherry picked from commit ed28fdc)
@mergify mergify bot mentioned this pull request Apr 6, 2022
Merged
mergify bot pushed a commit that referenced this pull request Apr 6, 2022
@toteki
chore: v2 module replace (#754)
de4a654 
* all replaces EXCEPT in price feeder

* fix make proto-gen output folder to allow major versions

(cherry picked from commit ed28fdc)
@mergify mergify bot mentioned this pull request Apr 6, 2022
Merged
toteki added a commit that referenced this pull request Apr 6, 2022
@mergify @toteki
chore: v2 module replace (#754) (#769)
42f5754 
* all replaces EXCEPT in price feeder

* fix make proto-gen output folder to allow major versions

(cherry picked from commit ed28fdc)

Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
toteki added a commit that referenced this pull request Apr 6, 2022
@mergify @toteki
chore: v2 module replace (#754) (#770)
4238fa7 
* all replaces EXCEPT in price feeder

* fix make proto-gen output folder to allow major versions

(cherry picked from commit ed28fdc)

Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
This was referenced Apr 19, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toteki @RafilxTenfen